[plugin] Improved the example code to encourage usage of optional arguments - #2212
Merged
Conversation
The example code had the `plugin` argument as the last argument. this disallows arguments that have a standard value. As far as I understand the dispatching code the order of arguments does not matter since it is the name `plugin` that is relevant. Therefor I changed the order so that newbe's don't have to read the entire code and can easily add optional arguments
cdecker
reviewed
Jan 2, 2019
cdecker
left a comment
cdecker
left a comment
Member
There was a problem hiding this comment.
Just a minor stylistic correction.
added small stylistic fix by @cdecker (sorry I made that original fix also on the github editor which did not have autosave actions) Co-Authored-By: renepickhardt <rene@rene-pickhardt.de>
Collaborator
Author
|
I have accepted your in git addition. thus it should be ready to be merged. |
Member
|
ACK 4db3f47 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The example code had the
pluginargument as the last argument. this disallows arguments that have a standard value. As far as I understand the dispatching code the order of arguments does not matter since it is the namepluginthat is relevant. Therefor I changed the order so that newbe's don't have to read the entire code and can easily add optional arguments