Missing declarations - #2775
Closed
ZmnSCPxj wants to merge 1 commit into
Closed
Conversation
Member
|
I don't think we should pipe cleanups into the release while we have an RC in flight, hence the 0.7.2 milestone 😉 ACK c9eb576 |
Contributor
Author
|
Rebased on top of #2783 . |
rustyrussell
reviewed
Jul 1, 2019
rustyrussell
left a comment
rustyrussell
left a comment
Contributor
There was a problem hiding this comment.
This is declared in common/json_command.h because there are two implementations; one for libplugin and one for lightningd.
So I think this PR should be closed...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Minor, does not change compilation, just fix up warnings. Probably safe to add to 0.7.1.