Skip to content

Cleanup for payment_hash - #2939

Merged
ZmnSCPxj merged 3 commits into
ElementsProject:masterfrom
trueptolemy:payment-hash-cleanup
Aug 21, 2019
Merged

Cleanup for payment_hash#2939
ZmnSCPxj merged 3 commits into
ElementsProject:masterfrom
trueptolemy:payment-hash-cleanup

Conversation

@trueptolemy

Copy link
Copy Markdown
Contributor

As discussed, now the payment_hash use struct sha256.

@trueptolemy
trueptolemy requested a review from cdecker as a code owner August 10, 2019 09:35
@darosior

Copy link
Copy Markdown
Contributor

ACK 43468a0
nice catch :-)

@cdecker cdecker added this to the 0.7.3 milestone Aug 12, 2019
@cdecker

cdecker commented Aug 20, 2019

Copy link
Copy Markdown
Member

Now needs a rebase 😉

@trueptolemy
trueptolemy force-pushed the payment-hash-cleanup branch from 43468a0 to fe857c2 Compare August 20, 2019 19:39
@trueptolemy

Copy link
Copy Markdown
Contributor Author

Rebased :-)

@ZmnSCPxj ZmnSCPxj left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK fe857c2

I would have preferred merging 2nd and 3rd commits into a single one but this is perfectly fine too.

@ZmnSCPxj
ZmnSCPxj merged commit 4929034 into ElementsProject:master Aug 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants