Skip to content

lightningd: pass version to env when plugin starts #2961

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
niftynei merged 2 commits into from Aug 26, 2019
Merged

lightningd: pass version to env when plugin starts #2961

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
68c8f7f
lightningd/plugin: at plugin start, set env LIGHTNINGD_VERSION
Aug 14, 2019
6e01134
pylightning/plugin: add `lightning_version` member to plugin
Aug 23, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions contrib/pylightning/lightning/plugin.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,6 +111,9 @@ def __init__(self, stdout=None, stdin=None, autopatch=True, dynamic=True):
if not stdin:
self.stdin = sys.stdin

self.lightning_version = None
if os.getenv('LIGHTNINGD_VERSION'):
self.lightning_version = os.getenv('LIGHTNINGD_VERSION')
if os.getenv('LIGHTNINGD_PLUGIN') and autopatch:
monkey_patch(self, stdout=True, stderr=True)

Expand Down
2 changes: 2 additions & 0 deletions lightningd/plugin.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@
#include <common/memleak.h>
#include <common/param.h>
#include <common/timeout.h>
#include <common/version.h>
#include <dirent.h>
#include <errno.h>
#include <lightningd/io_loop_with_timers.h>
Expand Down Expand Up @@ -1012,6 +1013,7 @@ void plugins_init(struct plugins *plugins, const char *dev_plugin_debug)
path_join(tmpctx, plugins->ld->config_dir, "plugins"));

setenv("LIGHTNINGD_PLUGIN", "1", 1);
Comment thread
This conversation was marked as resolved.
setenv("LIGHTNINGD_VERSION", version(), 1);
/* Spawn the plugin processes before entering the io_loop */
plugins_start(plugins, dev_plugin_debug);

Expand Down