Skip to content

Core sendpay fixes - #3860

Merged
cdecker merged 3 commits into
ElementsProject:masterfrom
rustyrussell:guilt/no-mpp-pay-after-success
Jul 21, 2020
Merged

Core sendpay fixes#3860
cdecker merged 3 commits into
ElementsProject:masterfrom
rustyrussell:guilt/no-mpp-pay-after-success

Conversation

@rustyrussell

@rustyrussell rustyrussell commented Jul 21, 2020

Copy link
Copy Markdown
Contributor

Changelog-None

This wasn't important before, but now we have MPP it's good to enforce.

Reported-by: Christian Decker
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
The test had part 1 and 2 backward, but still worked.  When I copied that to
*after* the test had succeeded, it complained.  It should always complain,
to catch bugs.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
@rustyrussell rustyrussell added this to the v0.9.0 milestone Jul 21, 2020
@rustyrussell
rustyrussell requested a review from cdecker July 21, 2020 04:23
@rustyrussell

Copy link
Copy Markdown
Contributor Author

I am running this now merged with #3857...

@cdecker

cdecker commented Jul 21, 2020

Copy link
Copy Markdown
Member

Very good changes independently of #3857, merging now 👍

ACK 72e735e

@cdecker
cdecker merged commit 23af241 into ElementsProject:master Jul 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants