Skip to content

plugins/pay: revert 899a2e64b02d47fc3aa68d70b9f483c2e8d7d685, use routehints in order. #3866

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rustyrussell wants to merge 2 commits into from
Closed

plugins/pay: revert 899a2e64b02d47fc3aa68d70b9f483c2e8d7d685, use routehints in order. #3866

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
266d1c5
plugins/pay: revert 899a2e64b02d47fc3aa68d70b9f483c2e8d7d685, use rou…
rustyrussell Jul 23, 2020
8d00b01
paymod: fix typo which can cause memory overrun.
rustyrussell Jul 23, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion plugins/libplugin-pay.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1756,7 +1756,7 @@ static bool routehint_excluded(struct payment *p,
* are suggesting we use it the other way. Very unlikely though! */
for (size_t i = 0; i < tal_count(routehint); i++) {
const struct route_info *r = &routehint[i];
for (size_t j=0; tal_count(nodes); j++)
for (size_t j = 0; j < tal_count(nodes); j++)
if (node_id_eq(&r->pubkey, &nodes[j]))
return true;

Expand Down
3 changes: 3 additions & 0 deletions plugins/libplugin-pay.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -232,6 +232,9 @@ struct payment {
struct channel_hint *channel_hints;
struct node_id *excluded_nodes;

/* Optional temporarily excluded channel (i.e. this routehint) */
struct short_channel_id *temp_exclusion;

struct payment_result *result;

/* Did something happen that will cause all future attempts to fail?
Expand Down