Skip to content

paymod: fix typo which can cause memory overrun. - #3869

Merged
cdecker merged 1 commit into
masterfrom
route-mem-overrun
Jul 23, 2020
Merged

paymod: fix typo which can cause memory overrun.#3869
cdecker merged 1 commit into
masterfrom
route-mem-overrun

Conversation

@cdecker

@cdecker cdecker commented Jul 23, 2020

Copy link
Copy Markdown
Member

Split out from #3866 since it was unrelated and needs to go in independently.

Signed-off-by: Rusty Russell rusty@rustcorp.com.au
Changelog-None
Closes #3866

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>

@ZmnSCPxj ZmnSCPxj left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 68d8c5d

Comment thread plugins/libplugin-pay.c
for (size_t i = 0; i < tal_count(routehint); i++) {
const struct route_info *r = &routehint[i];
for (size_t j=0; tal_count(nodes); j++)
for (size_t j = 0; j < tal_count(nodes); j++)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

uuuuuuuuuugh

@cdecker
cdecker merged commit 497b18b into master Jul 23, 2020
@rustyrussell
rustyrussell deleted the route-mem-overrun branch August 15, 2022 00:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants