Restore dual-funding GitHub CI#4683
Merged
niftynei merged 5 commits intoElementsProject:masterfrom Aug 5, 2021
Merged
Conversation
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
dualopend doesn't always listen to lightningd messages, so it would sometimes hang at the end of tests. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Naively calling bump with the next feerate doesnt add enough extra to get over the min-relay requirement for RBF.
fixes: FAILED tests/test_connection.py::test_funding_v2_corners - Failed: DID NOT RAISE
niftynei
force-pushed
the
guilt/restore-df-ci
branch
from
de6512f to
a19b6fb
Compare
Collaborator
|
dual-funding is fixed, flakes are just flakes ACK a19b6fb |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I just realized this isn't being tested! Did some quick fixes, but it still fails.