Return the correct channel_update when erring#4876
Merged
cdecker merged 2 commits intoElementsProject:masterfrom Oct 21, 2021
Merged
Return the correct channel_update when erring#4876cdecker merged 2 commits intoElementsProject:masterfrom
channel_update when erring#4876cdecker merged 2 commits intoElementsProject:masterfrom
Conversation
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
We can have an update pending because it's too fast, but refresh_local_channel is supposed to make sure we're up-to-date, so force immediate application in that case. Otherwise, we call update_local_channel at the bottom which frees the pending update. This can mean that we miss a change in fees, for example. Changelog-Fixed: errors: Errors returning a `channel_update` no longer return an outdated one. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a spinoff from #4808 which includes the fix for outdated
channel_updateswhen one is already queued for broadcast.