Skip to content

renepay: hack in workaround spendable reduction for release. - #6601

Merged
rustyrussell merged 1 commit into
ElementsProject:masterfrom
rustyrussell:guilt/renepay-hack
Aug 23, 2023
Merged

renepay: hack in workaround spendable reduction for release.#6601
rustyrussell merged 1 commit into
ElementsProject:masterfrom
rustyrussell:guilt/renepay-hack

Conversation

@rustyrussell

@rustyrussell rustyrussell commented Aug 23, 2023

Copy link
Copy Markdown
Contributor
Flow 391: amount=23528000msat prob=0.000 fees=1023msat delay=140 path=-2471854x37x4/1(min=max=23528783msat)->-2414928x98x0/0->
Flow 391: Failure of 23529023msat for 2471854x37x4/1 capacity [23528783msat,23528783msat] -> [23528783msat,23528783msat]

We added fees and went over capacity! This screams of a deeper logic bug, but renepay is experimental and it's release day so hack around it for now...

Reported-by: https://github.com/daywalker90
See: #6599

```
Flow 391: amount=23528000msat prob=0.000 fees=1023msat delay=140 path=-2471854x37x4/1(min=max=23528783msat)->-2414928x98x0/0->
Flow 391: Failure of 23529023msat for 2471854x37x4/1 capacity [23528783msat,23528783msat] -> [23528783msat,23528783msat]
```

We added fees and went over capacity!  This screams of a deeper logic
bug, but renepay is experimental and it's release day so hack around
it for now...

Reported-by: https://github.com/daywalker90
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
@rustyrussell rustyrussell added the Type::Bug An error, flaw, or fault that produces an incorrect or unexpected result label Aug 23, 2023
@rustyrussell rustyrussell added this to the v23.08 milestone Aug 23, 2023
@rustyrussell
rustyrussell requested a review from Lagrang3 August 23, 2023 01:24
@rustyrussell
rustyrussell merged commit 7cd4359 into ElementsProject:master Aug 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Type::Bug An error, flaw, or fault that produces an incorrect or unexpected result

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant