splice: Gossip new scid on splice_lock - #6694
Closed
ddustin wants to merge 1 commit into
Closed
Conversation
ddustin
marked this pull request as draft
September 19, 2023 19:23
ddustin
force-pushed
the
ddustin/splice_gossip
branch
from
September 19, 2023 21:02
ce3e7bd to
4816dcd
Compare
Reset scid announced flag so the gossip system can re-announce it, and add test the confirm the new channel is seen after 6 blcoks and the old one drops after 12+ blocks. ChageLog-Fixed: Scid gossip fix for splices.
ddustin
force-pushed
the
ddustin/splice_gossip
branch
from
September 19, 2023 21:04
4816dcd to
b0af2a2
Compare
ddustin
marked this pull request as ready for review
September 19, 2023 21:06
Collaborator
Author
|
Merging into #6677 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reset scid announced flag so the gossip system can re-announce it.
Fixes #6572
Fixes #6481
Todo: