Gossip rework part 2

.gitmodules

@@ -14,9 +14,6 @@
 [submodule "external/gheap"]
 	path = external/gheap
 	url = https://github.com/valyala/gheap
-[submodule "external/lnprototest"]
-	path = external/lnprototest
-	url = https://github.com/rustyrussell/lnprototest.git
 [submodule "external/lowdown"]
 	path = external/lowdown
 	url = https://github.com/kristapsdz/lowdown.git

.msggen.json

@@ -939,6 +939,7 @@
             "ListClosedChannels.closedchannels[].funding_txid": 12,
             "ListClosedChannels.closedchannels[].last_commitment_fee_msat": 23,
             "ListClosedChannels.closedchannels[].last_commitment_txid": 22,
+            "ListClosedChannels.closedchannels[].last_stable_connection": 25,
             "ListClosedChannels.closedchannels[].leased": 14,
             "ListClosedChannels.closedchannels[].max_to_us_msat": 21,
             "ListClosedChannels.closedchannels[].min_to_us_msat": 20,
@@ -1147,6 +1148,7 @@
             "ListPeerChannels.channels[].inflight[]": 16,
             "ListPeerChannels.channels[].initial_feerate": 12,
             "ListPeerChannels.channels[].last_feerate": 13,
+            "ListPeerChannels.channels[].last_stable_connection": 56,
             "ListPeerChannels.channels[].max_accepted_htlcs": 40,
             "ListPeerChannels.channels[].max_to_us_msat": 25,
             "ListPeerChannels.channels[].max_total_htlc_in_msat": 30,
@@ -3676,6 +3678,10 @@
             "added": "pre-v0.10.1",
             "deprecated": false
         },
+        "ListClosedChannels.closedchannels[].last_stable_connection": {
+            "added": "v24.02",
+            "deprecated": false
+        },
         "ListClosedChannels.closedchannels[].leased": {
             "added": "pre-v0.10.1",
             "deprecated": false
@@ -4408,6 +4414,10 @@
             "added": "v23.02",
             "deprecated": false
         },
+        "ListPeerChannels.channels[].last_stable_connection": {
+            "added": "v24.02",
+            "deprecated": false
+        },
         "ListPeerChannels.channels[].max_accepted_htlcs": {
             "added": "v23.02",
             "deprecated": false

Makefile

@@ -72,7 +72,7 @@ endif
 
 # (method=thread to support xdist)
 PYTEST_OPTS := -v -p no:logging $(PYTEST_OPTS)
-MY_CHECK_PYTHONPATH=$${PYTHONPATH}$${PYTHONPATH:+:}$(shell pwd)/contrib/pyln-client:$(shell pwd)/contrib/pyln-testing:$(shell pwd)/contrib/pyln-proto/:$(shell pwd)/external/lnprototest:$(shell pwd)/contrib/pyln-spec/bolt1:$(shell pwd)/contrib/pyln-spec/bolt2:$(shell pwd)/contrib/pyln-spec/bolt4:$(shell pwd)/contrib/pyln-spec/bolt7
+MY_CHECK_PYTHONPATH=$${PYTHONPATH}$${PYTHONPATH:+:}$(shell pwd)/contrib/pyln-client:$(shell pwd)/contrib/pyln-testing:$(shell pwd)/contrib/pyln-proto/:$(shell pwd)/contrib/pyln-spec/bolt1:$(shell pwd)/contrib/pyln-spec/bolt2:$(shell pwd)/contrib/pyln-spec/bolt4:$(shell pwd)/contrib/pyln-spec/bolt7
 # Collect generated python files to be excluded from lint checks
 PYTHON_GENERATED= \
 	contrib/pyln-grpc-proto/pyln/grpc/primitives_pb2.py \
@@ -453,14 +453,7 @@ endif
 
 check-units:
 
-check: check-units installcheck check-protos pytest
-
-check-protos: $(ALL_PROGRAMS)
-ifeq ($(PYTEST),)
-	@echo "py.test is required to run the protocol tests, please install using 'pip3 install -r requirements.txt', and rerun 'configure'."; false
-else
-	@(cd external/lnprototest && PYTHONPATH=$(MY_CHECK_PYTHONPATH) LIGHTNING_SRC=../.. $(PYTEST) --runner lnprototest.clightning.Runner $(PYTEST_OPTS))
-endif
+check: check-units installcheck pytest
 
 pytest: $(ALL_PROGRAMS) $(DEFAULT_TARGETS) $(ALL_TEST_PROGRAMS) $(ALL_TEST_GEN)
 ifeq ($(PYTEST),)

channeld/Makefile

@@ -83,7 +83,6 @@ CHANNELD_COMMON_OBJS :=				\
 	common/psbt_keypath.o		\
 	common/psbt_open.o			\
 	common/psbt_internal.o			\
-	common/private_channel_announcement.o	\
 	common/pseudorand.o			\
 	common/read_peer_msg.o			\
 	common/setup.o				\