ci: Split fuzzing out of the PR testing - #7029
Merged
Merged
Conversation
cdecker
enabled auto-merge (rebase)
February 1, 2024 16:59
Tacking the fuzz testing onto the PR testing not a good idea. It causes completely unrelated tests to fail, and doesn't guarantee it will find newly introduced ones. Running daily is likely better. Changelog-None No user visible change
cdecker
force-pushed
the
202404-split-fuzz-ci
branch
from
February 1, 2024 17:52
d3f6245 to
558463b
Compare
morehouse
suggested changes
Feb 1, 2024
morehouse
left a comment
morehouse
left a comment
Contributor
There was a problem hiding this comment.
This is for regression testing, not a "side quest". If a new PR breaks a fuzzing regression test, it's better to fix before merging.
Contributor
|
NACK, for the record... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fuzz testing as a side-quest while verifying the correctness of a PR is strange. Lets not do that.