schema: add missing option_will_fund for listnodes - #7210
Closed
daywalker90 wants to merge 2 commits into
Closed
Conversation
daywalker90
force-pushed
the
listnodes-schema-fix
branch
2 times, most recently
from
April 11, 2024 20:36
110f9b1 to
02b749d
Compare
Collaborator
Author
|
So my removing of all |
Changelog-None
daywalker90
force-pushed
the
listnodes-schema-fix
branch
from
April 11, 2024 20:45
02b749d to
78fa319
Compare
Collaborator
Author
|
apparently i broke a test that i don't yet understand |
daywalker90
marked this pull request as draft
April 11, 2024 21:40
daywalker90
marked this pull request as ready for review
April 12, 2024 13:30
daywalker90
marked this pull request as draft
April 14, 2024 14:47
Collaborator
Author
|
I think i found a big fix for msggen that makes this obsolete |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ok ok i did not adhere to the writing-json-schemas.md guideline for conditional fields but it just didn't want to work when i tried.
This is me learning json schemas and msggen so bear with me please. I'll plan on doing as much as i can if this works out :)
Note that i also made
addressinaddressesno longer optional since there is no scenario where it is on >23.08fixes: #7185