msggen: add commando, commando-rune, commando-listrunes, commando-blacklist methods - #7269
Closed
daywalker90 wants to merge 1 commit into
Closed
msggen: add commando, commando-rune, commando-listrunes, commando-blacklist methods#7269daywalker90 wants to merge 1 commit into
daywalker90 wants to merge 1 commit into
Conversation
…cklist methods Changelog-None
Contributor
|
These are deprecated except for Commando is recursive, though, which makes this difficult to define! |
Collaborator
|
Closing in favour of PR #7209. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this adds:
But they are incomplete. Missing fields because of
OneOfcomplexity in the schemas:Commando.params, unsure what do here since object can't know what fields it will have and array would require all positional args to be present if i understand this correctlyCommandoResponsehow to define the response of this command?Commando-rune.restrictionsis either a string or an array of an array of strings. Can this be simplified to just an array of strings?