schemas: use sat and sat_or_all again where appropiate - #7336
Merged
Conversation
Changelog-None
ShahanaFarooqui
self-requested a review
May 24, 2024 16:52
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
|
|
||
|
|
||
| def amount2sat(a): | ||
| return a.msat / 1000 |
Collaborator
There was a problem hiding this comment.
Suggested change
| return a.msat / 1000 | |
| return a.msat // 1000 |
Do we want integer division here? Any remainder after division should indicate a problem, but if we're only using it to directly convert types it shouldn't theoretically be an issue.
Collaborator
Author
There was a problem hiding this comment.
I assumed an Amount already is a correctly parsed value and this should be fine, otherwise we should raise an error here, no?
For multifund and openchannel_init schemas, request_amt type is also `sat`.
ShahanaFarooqui
force-pushed
the
satisfaction
branch
from
May 25, 2024 00:27
33e3d69 to
1727e75
Compare
Collaborator
|
ACK 1727e75 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is in response to #7333 and #7230 (comment)