Release v25.09.4#8746
Closed
rustyrussell wants to merge 5 commits intoElementsProject:release-v25.09.3from
Closed
Conversation
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
At startup, we load the outpoints to watch, *then* roll back 15 blocks. If there were things in those blocks we wanted to watch, we no longer do! 1. We load the utxoset into memory: everything in the utxoset table which has spendheight null. 2. We roll back 15 blocks to re-read. Deleting a block from the database causes the utxo spentheights referring to it to be set to null. 3. We roll forward, but we didn't update the in-memory utxoset, so we're not watching those utxos which are spent. The main symptom of this is that we spam peers with obsolete gossip (if we get sent a channel announcement for a closed channel, we can think it isn't spent yet). But it could *also* mean we don't notice onchain txs, if we restart at the wrong time! Changelog-Fixed: lightningd: we could miss tx spends which happened in the past blocks when we restarted. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
We only do this once, and not on new nodes. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
I took the node from the original test which missed the UTXO, and added some more blocks. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Contributor
Author
|
I'm closing this, since it fell outside the support window before release. The user who complained did use the tagged version, however. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The critical "missing UTXOS" fix.
Changelog-None