msggen: new rust types for sat and sat_or_all - #9275
Merged
daywalker90 merged 1 commit intoJul 17, 2026
Conversation
daywalker90
force-pushed
the
cln-rpc-msat-purge
branch
from
July 3, 2026 09:15
99ca019 to
ff31879
Compare
daywalker90
added
the
Status::Ready for Review
nepet
previously approved these changes
Jul 3, 2026
daywalker90
force-pushed
the
cln-rpc-msat-purge
branch
from
July 3, 2026 10:24
ff31879 to
128710c
Compare
Collaborator
Author
|
CI found an integration test that fails with this change: So i fixed: test_lsps2_buyjitchannel_mpp_fixed_invoice
- amount_msat=f"{amt}msat",
+ amount_msat=amt,This tests is quite new and i hope on the other end no one is using msat suffixes anymore?! |
daywalker90
marked this pull request as draft
July 3, 2026 13:31
daywalker90
removed
the
Status::Ready for Review
daywalker90
force-pushed
the
cln-rpc-msat-purge
branch
from
July 6, 2026 13:48
128710c to
37e7fed
Compare
daywalker90
changed the title
sat and sat_or_all
Collaborator
Author
|
I have reworked this PR to introduce a new rust type for satoshi unit amounts. See the linked issue for an explanation. |
daywalker90
marked this pull request as ready for review
July 6, 2026 13:54
daywalker90
force-pushed
the
cln-rpc-msat-purge
branch
from
July 6, 2026 14:17
37e7fed to
4c08cba
Compare
Also stop serializing amounts as string with msat suffix in cln-rpc and serialize them as a raw number instead, like CLN does it Changelog-None
daywalker90
force-pushed
the
cln-rpc-msat-purge
branch
from
July 10, 2026 12:43
4c08cba to
f2c029f
Compare
madelinevibes
added
the
Status::Ready for Review
cdecker
approved these changes
Jul 16, 2026
Member
|
Looking very good. Thank you 😊 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Drop conversion to string and instead implement DisplayChangelog-None