This repository was archived by the owner on Oct 31, 2025. It is now read-only.
entry: apply NonWritable to read-only StorageBuffers.#1011
Merged
eddyb merged 2 commits intoEmbarkStudios:mainfrom Apr 4, 2023
LykenSol:non-writable
Merged
entry: apply NonWritable to read-only StorageBuffers.#1011eddyb merged 2 commits intoEmbarkStudios:mainfrom LykenSol:non-writable
NonWritable to read-only StorageBuffers.#1011eddyb merged 2 commits intoEmbarkStudios:mainfrom
LykenSol:non-writable
Conversation
This was referenced Mar 20, 2023
Open
oisyn
approved these changes
Mar 27, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR applies
NonWritableto#[spirv(storage_buffer)] x: &T(ifTdoesn't have interior mutability).NonReadable)(also we should maybe do something different for storage images?)
StorageBufferas, according tospirv-val, only it andUniformallowNonWritable, andUniformbuffers are always read-only anywaywgpuread-only-storagebuffers are stricter than their Vulkan counterparts)