This repository was archived by the owner on Oct 31, 2025. It is now read-only.
builder: use undef bool instead of false, for checked_binop's zombie.#1025
Merged
eddyb merged 1 commit intoEmbarkStudios:mainfrom Apr 5, 2023
LykenSol:checked-add-zombie-false
Merged
builder: use undef bool instead of false, for checked_binop's zombie.#1025eddyb merged 1 commit intoEmbarkStudios:mainfrom LykenSol:checked-add-zombie-false
bool instead of false, for checked_binop's zombie.#1025eddyb merged 1 commit intoEmbarkStudios:mainfrom
LykenSol:checked-add-zombie-false
Conversation
oisyn
approved these changes
Apr 5, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
falseconstants, sincenightly-2023-03-04. #1024The actual fix was tiny, but testing required going through some hoops, as the original issue only seemed to reproduce with
--release(ironically, given the checked overflow connection).In the end I went with
-Ccodegen-units=1(to try and force the user'sboolconstants to overlap the zombie), but I'm not 100% sure that's future-proof. But it did reproduce, i.e. w/o the fix, the test errors with: