This repository was archived by the owner on Oct 31, 2025. It is now read-only.
Inliner: rewrite IDs on decorations fix#1059
Merged
eddyb merged 2 commits intoEmbarkStudios:mainfrom May 26, 2023
SiebenCorgie:inliner-id-rewrite-decoratio-fix
Merged
Inliner: rewrite IDs on decorations fix#1059eddyb merged 2 commits intoEmbarkStudios:mainfrom SiebenCorgie:inliner-id-rewrite-decoratio-fix
eddyb merged 2 commits intoEmbarkStudios:mainfrom
SiebenCorgie:inliner-id-rewrite-decoratio-fix
Conversation
eddyb
suggested changes
May 5, 2023
eddyb
suggested changes
May 26, 2023
| // NOTE(siebencorgie): We don't care *what* decoration we rewrite atm. AFAIK there is no case where rewriting | ||
| // the decoration on inline wouldn't be valid. | ||
| for annotation_idx in 0..self.annotations.len() { | ||
| if self.annotations[annotation_idx].class.opcode == Op::Decorate { |
Contributor
There was a problem hiding this comment.
Hmm this is enough for your usecase but it should be possible to extend it to all decorate instructions (which I'll need for late zombie reporting).
eddyb
approved these changes
May 26, 2023
auto-merge was automatically disabled
May 26, 2023 16:28
Rebase failed
Contributor
|
Sorry for the force push to your branch, had to rebase it to land it (I wonder if it's because of the merge commit you had - next time, use |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the inliner only rewrites IDs in the 'inlined_callee_blocks'. Therefore 'OpDecorate %id' on any '%id' that is rewritten is lost in this pass.
This fix applies the rewrite rules to all decorations as well.