Add support for SPV_KHR_ray_tracing by XAMPPRocky · Pull Request #563 · EmbarkStudios/rust-gpu

XAMPPRocky · 2021-03-31T09:19:05Z

This PR adds initial support for ray tracing in Rust-GPU.

~~Currently the tests don't pass because I ran into some ICE's when testing OpTerminateRayKHR. Filed as #564~~

XAMPPRocky · 2021-03-31T09:20:36Z

cc @hrydgard @repi

repi · 2021-03-31T09:27:52Z

Cool!

hrydgard · 2021-03-31T10:00:47Z

Very cool!

To actually do real shading once we hit stuff with rays though, we need to be able to look up mesh data by mesh ID, which will likely end up requiring some of #450 or preferably #569 .

crates/rustc_codegen_spirv/src/symbols.rs

tests/ui/arch/trace_ray_khr.rs

crates/rustc_codegen_spirv/Cargo.toml

crates/spirv-std/src/ray_tracing.rs

crates/spirv-std/src/arch/ray_tracing.rs

khyperia

LGTM, I'd also like a review from @eddyb

crates/rustc_codegen_spirv/src/spirv_type_constraints.rs

crates/rustc_codegen_spirv/src/linker/new_structurizer.rs

XAMPPRocky · 2021-04-16T05:48:01Z

r? @eddyb

crates/rustc_codegen_spirv/src/spirv_type_constraints.rs

* Add support for SPV_KHR_ray_tracing * Update spirv_type_constraints.rs * Update spirv_type_constraints.rs * Update spirv_type_constraints.rs

XAMPPRocky requested review from eddyb and khyperia as code owners March 31, 2021 09:19

XAMPPRocky requested a review from Jasper-Bekkers March 31, 2021 09:20

XAMPPRocky mentioned this pull request Mar 31, 2021

Add support for generating OpTypeAccelerationStructureKHR gfx-rs/rspirv#187

Closed

XAMPPRocky force-pushed the ray-tracing-khr branch from da59652 to 281f4bc Compare March 31, 2021 09:34

hrydgard reviewed Mar 31, 2021

View reviewed changes

crates/rustc_codegen_spirv/src/symbols.rs Outdated Show resolved Hide resolved

XAMPPRocky force-pushed the ray-tracing-khr branch 2 times, most recently from 5fe8d7a to 7a4b997 Compare March 31, 2021 11:34

hrydgard reviewed Mar 31, 2021

View reviewed changes

crates/rustc_codegen_spirv/src/symbols.rs Outdated Show resolved Hide resolved

XAMPPRocky force-pushed the ray-tracing-khr branch 2 times, most recently from 5747b73 to 04c3476 Compare March 31, 2021 13:37

hrydgard reviewed Mar 31, 2021

View reviewed changes

tests/ui/arch/trace_ray_khr.rs Outdated Show resolved Hide resolved

XAMPPRocky force-pushed the ray-tracing-khr branch from 985311c to 5504a1e Compare March 31, 2021 17:47

XAMPPRocky mentioned this pull request Mar 31, 2021

Add support for SPV_KHR_ray_query #572

Merged

khyperia suggested changes Apr 1, 2021

View reviewed changes

crates/rustc_codegen_spirv/Cargo.toml Outdated Show resolved Hide resolved

crates/spirv-std/src/ray_tracing.rs Outdated Show resolved Hide resolved

khyperia mentioned this pull request Apr 1, 2021

structurizer: split regions into Divergent vs Convergent, and optimize based on that. #574

Closed

XAMPPRocky force-pushed the ray-tracing-khr branch from 5504a1e to 9ab3083 Compare April 1, 2021 09:04

XAMPPRocky requested a review from khyperia April 1, 2021 09:08

XAMPPRocky force-pushed the ray-tracing-khr branch from 9ab3083 to accfe3e Compare April 1, 2021 09:20

khyperia reviewed Apr 1, 2021

View reviewed changes

crates/spirv-std/src/arch/ray_tracing.rs Outdated Show resolved Hide resolved

XAMPPRocky force-pushed the ray-tracing-khr branch from accfe3e to 7f688b8 Compare April 1, 2021 09:59

Jasper-Bekkers reviewed Apr 1, 2021

View reviewed changes

crates/spirv-std/src/arch/ray_tracing.rs Outdated Show resolved Hide resolved

XAMPPRocky force-pushed the ray-tracing-khr branch 5 times, most recently from a567b5d to e11a269 Compare April 15, 2021 10:23

XAMPPRocky force-pushed the ray-tracing-khr branch from e11a269 to d4421b0 Compare April 15, 2021 10:49

khyperia suggested changes Apr 15, 2021

View reviewed changes

crates/spirv-std/src/arch/ray_tracing.rs Outdated Show resolved Hide resolved

crates/spirv-std/src/arch/ray_tracing.rs Outdated Show resolved Hide resolved

crates/spirv-std/src/arch/ray_tracing.rs Show resolved Hide resolved

XAMPPRocky force-pushed the ray-tracing-khr branch 3 times, most recently from d864cff to 82d8250 Compare April 15, 2021 13:01

XAMPPRocky requested a review from khyperia April 15, 2021 13:26

khyperia approved these changes Apr 15, 2021

View reviewed changes

eddyb suggested changes Apr 15, 2021

View reviewed changes

crates/rustc_codegen_spirv/src/spirv_type_constraints.rs Outdated Show resolved Hide resolved

crates/rustc_codegen_spirv/src/linker/new_structurizer.rs Show resolved Hide resolved

Add support for SPV_KHR_ray_tracing

1f51975

XAMPPRocky force-pushed the ray-tracing-khr branch from 82d8250 to 1f51975 Compare April 16, 2021 05:47

XAMPPRocky requested a review from eddyb April 16, 2021 05:48

XAMPPRocky added 3 commits April 16, 2021 09:38

Update spirv_type_constraints.rs

7d60d49

Update spirv_type_constraints.rs

1fffed8

Update spirv_type_constraints.rs

d09d797

eddyb approved these changes Apr 16, 2021

View reviewed changes

eddyb enabled auto-merge (squash) April 16, 2021 07:53

XAMPPRocky added 2 commits April 16, 2021 11:37

Update spirv_type_constraints.rs

f3a446f

Update spirv_type_constraints.rs

f9b4737

eddyb suggested changes Apr 16, 2021

View reviewed changes

crates/rustc_codegen_spirv/src/spirv_type_constraints.rs Outdated Show resolved Hide resolved

XAMPPRocky commented Apr 16, 2021

View reviewed changes

crates/rustc_codegen_spirv/src/spirv_type_constraints.rs Outdated Show resolved Hide resolved

Update crates/rustc_codegen_spirv/src/spirv_type_constraints.rs

3e92b02

XAMPPRocky requested a review from eddyb April 16, 2021 10:43

eddyb approved these changes Apr 16, 2021

View reviewed changes

eddyb merged commit a42a9f2 into main Apr 16, 2021

eddyb deleted the ray-tracing-khr branch April 16, 2021 13:59

XAMPPRocky added a commit that referenced this pull request May 3, 2021

Add support for SPV_KHR_ray_tracing (#563)

d1ddf30

* Add support for SPV_KHR_ray_tracing * Update spirv_type_constraints.rs * Update spirv_type_constraints.rs * Update spirv_type_constraints.rs

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add support for SPV_KHR_ray_tracing#563

Add support for SPV_KHR_ray_tracing#563
eddyb merged 7 commits intomainfrom
ray-tracing-khr

XAMPPRocky commented Mar 31, 2021 •

edited

Loading

Uh oh!

XAMPPRocky commented Mar 31, 2021

Uh oh!

repi commented Mar 31, 2021

Uh oh!

hrydgard commented Mar 31, 2021 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

khyperia left a comment

Uh oh!

Uh oh!

Uh oh!

XAMPPRocky commented Apr 16, 2021

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Conversation

XAMPPRocky commented Mar 31, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

XAMPPRocky commented Mar 31, 2021

Uh oh!

repi commented Mar 31, 2021

Uh oh!

hrydgard commented Mar 31, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

khyperia left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

XAMPPRocky commented Apr 16, 2021

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

XAMPPRocky commented Mar 31, 2021 •

edited

Loading

hrydgard commented Mar 31, 2021 •

edited

Loading