This repository was archived by the owner on Oct 31, 2025. It is now read-only.
Merged
Conversation
We cannot use print_metadata with watching because print_metadata only makes sense in build scripts, but watching does not and would instead stall the script
Contributor
Author
|
I have produced a video showing how this works in the wgpu example runner: 2021-06-08.21-17-24.mp4 |
khyperia
reviewed
Jun 9, 2021
Contributor
khyperia
left a comment
khyperia
left a comment
There was a problem hiding this comment.
LGTM, just the two things!
Contributor
Pushed the exception! |
khyperia
approved these changes
Jun 9, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a (feature gated) implementation of hot shader reloading to SpirvBuilder
This attempts to handle initial compilation gracefully by watching the shader crate root recursively until we have more detailed dependency information
Unfortunately, notify uses a non-standard license (CC0) so we fail the cargo deny check. I will defer adding a commit which changes
deny.tomlto allow this to pass to the suitable Embarker (@XAMPPRocky ?)It appears that if there was sufficient demand for it, notify would be willing to update their license ( notify-rs/notify#243 (comment))
In theory, the CC0 license they are under is probably already MIT/Apache compatible, so
notifycould avoid getting new permissions from the contributors, but it would still be wise to notify (ha) them.(See e.g. this stackoverflow post (this is google's webcache since stackoverflow is down at the time of posting))
I'm also planning to integrate this into the example runner, but want to get the ball rolling on the license issues