This repository was archived by the owner on Oct 31, 2025. It is now read-only.
Conversation
eddyb
approved these changes
Oct 25, 2021
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Oh hey, wasn't even intending to fix
range-contains.rs, but here we are!I believe this is a first step towards improving #739 (better for loop codegen), although certainly not perfect right now (this cleans up the remaining three OpVariables generated from that repro program, but a bunch of composites to be cleaned up by SROA remain)
Please review the .stderr changes closely to make sure they're valid, I'm incredibly tired and brain-mush right now and am not 100% sure it's correct, haha