socket_comms: fix comms on Windows#131
Merged
Merged
Conversation
Make the COAP block timeout configurable from the command line. Signed-off-by: Jordan Yates <jordan@embeint.com>
Add the option to delete a KV entry from the `kv_write` RPC. Signed-off-by: Jordan Yates <jordan@embeint.com>
Since the cloud API does not differentiate between a "WAITING" command and one that has timed out, do the expiry check ourselves. Signed-off-by: Jordan Yates <jordan@embeint.com>
Don't explicitly bind to `localhost` when running on Windows. Signed-off-by: Jordan Yates <jordan@embeint.com>
Add a simple test for `comms_check` to ensure the logic works on all OS's in CI. Signed-off-by: Jordan Yates <jordan@embeint.com>
JordanYates
force-pushed
the
bugfix/socket_windows
branch
from
200f553 to
2b7dc1b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Don't explicitly bind to
localhostwhen running on Windows.