Skip to content

Fix SignatureHelp block other vscode extension issue#40

Merged
CppCXY merged 1 commit intoEmmyLua:masterfrom
yeweiran:master
Sep 24, 2022
Merged

Fix SignatureHelp block other vscode extension issue#40
CppCXY merged 1 commit intoEmmyLua:masterfrom
yeweiran:master

Conversation

@yeweiran
Copy link
Copy Markdown
Contributor

Related PR: #31
The SignatureHelp should return null if the list is empty, otherwise it will block other extension to show SignatureHelp.

@yeweiran
Copy link
Copy Markdown
Contributor Author

@CppCXY @tangzx Could you please take a look of this PR when you get time? This issue blocking our team using the plugin again. Much appreciated.

@CppCXY CppCXY merged commit 3e0e506 into EmmyLua:master Sep 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants