Merged
Conversation
added 8 commits
November 18, 2025 10:37
…e breaking changes) which increased performance.
… icons for all Nodes/Areas (as it is fine to combine custom icon with the default generated icons).
…bol, Any} types used as container for plotted data.
There was a problem hiding this comment.
Pull Request Overview
This PR updates Makie package versions to support Julia 1.12 and introduces performance optimizations. Key changes include:
- Replacing
Dict{Symbol,Any}structures with the new parametricPlotContainertype for better type stability - Adding
parentfield toEnergySystemDesignto track hierarchy directly - Enabling optional GeoMakie toggling for improved performance when maps aren't needed
- Refactoring color handling to use
RGBA{Float32}consistently throughout
Reviewed Changes
Copilot reviewed 19 out of 22 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| test/utils.jl | Updated function calls to use simplified API signatures |
| test/test_interactivity.jl | Replaced direct indexing with get_component helper function |
| src/utils_gen/topo_utils.jl | Removed unused toggle_inspector! function and updated parent access |
| src/utils_gen/structures_utils.jl | Added parse_color utility and improved color handling with RGBA{Float32} |
| src/utils_gen/export_utils.jl | Updated pretty_table API call from header to column_labels |
| src/utils_GUI/topo_axis_utils.jl | Optimized connection drawing logic and moved label placement calculation |
| src/utils_GUI/results_axis_utils.jl | Replaced Dict containers with typed PlotContainer structs |
| src/utils_GUI/event_functions.jl | Simplified selection clearing with unified symbol-based API |
| src/utils_GUI/GUI_utils.jl | Refactored selection color toggling and component picking logic |
| src/setup_topology.jl | Added parent tracking during design construction |
| src/setup_GUI.jl | Added GeoMakie toggle and data inspector configuration options |
| src/datastructures.jl | Introduced PlotContainer type and consolidated getter functions |
| ext/EMGExt/EMGExt.jl | Replaced custom area collection with EMG package function |
| docs/generate_images.jl | Updated to use get_name accessor for plot containers |
| docs/Project.toml | Added IntervalSets version constraint |
| README.md | Removed Julia 1.12 incompatibility warning |
| NEWS.md | Updated release notes with changes |
| .github/workflows/documentation.yml | Updated Julia version from 1.11 to latest |
| .github/workflows/ci.yml | Updated Julia version specifications |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Apply suggestions from Copilot review. Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
… examples (being activated when documentation CI is run).
…t is activated in the documentation.
dqpinel
approved these changes
Nov 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR finds workaround to update makie version which Fixes #24. The package can then be run with Julia version 1.12. A series of optimizations is also applied. Code structure has been improved by introducing the new types of
PlotContainerand other improvements. Toggeling of GeoMakie is also now available which improves performance if the background map is not required.