Skip to content

Fix TransmissionMode in "data"-menu#41

Merged
Zetison merged 2 commits intomainfrom
fix/transmissionmode_labeling
Dec 15, 2025
Merged

Fix TransmissionMode in "data"-menu#41
Zetison merged 2 commits intomainfrom
fix/transmissionmode_labeling

Conversation

@Zetison
Copy link
Collaborator

@Zetison Zetison commented Nov 25, 2025

Fix missing distinction between different TransmissionModes in the "data"-menu by including the id field in square brackets (actually, all non AbstractElement/Nothing elements are now included as indices in square brackets). Also expand TransmissionModes in the info-box.

This PR Fixes #32

…"data"-menu by including the `id` field in parantheses. Also, improve the info-box.
@Zetison Zetison requested a review from Copilot November 25, 2025 13:42
@Zetison Zetison self-assigned this Nov 25, 2025
@Zetison Zetison added the bug Something isn't working label Nov 25, 2025
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes the data menu labeling issue where different TransmissionModes were not properly distinguished, addressing issue #32. The fix includes all non-AbstractElement/Nothing elements as indices in square brackets in the data menu labels, and expands TransmissionModes in the info box.

Key changes:

  • Modified label creation to use square brackets for indices instead of parentheses for resources
  • Enhanced info box expansion to handle TransmissionModes specifically
  • Added test coverage for data menu labeling functionality

Reviewed changes

Copilot reviewed 9 out of 11 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
src/utils_GUI/results_axis_utils.jl Updated create_label to use square brackets for non-AbstractElement indices
src/utils_GUI/info_axis_utils.jl Refactored print_nested_structure! into type-specific methods and added Expandable type alias
ext/EMGExt/EMGExt.jl Added TransmissionMode vector printing support and simplified mode retrieval
src/utils_GUI/GUI_utils.jl Enhanced select_data! to support selection filtering
test/test_interactivity.jl Added test case for data menu labeling with transmission modes
test/utils.jl Added fetch_element helper function for tests
test/EMI_geography_2.jl Added H2_Transport_50MW_OT transmission mode to test data
src/utils_gen/structures_utils.jl Updated get_resource_colors to use unique(vcat(inputs(l), outputs(l)))
NEWS.md Documented the bugfix and enhancements

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@Zetison Zetison requested a review from espenfb November 25, 2025 14:01
Copy link
Member

@espenfb espenfb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fixes the issue with distincion of the parameters for different transmission modes nicely. The implementation looks good and I have no comments.

The print in the info-box could be a bit more styled, it is a bit long and some details could probably be skipped. But this should be done in a seperate Issue (it's the same for other elements such as nodes etc.).

@Zetison Zetison merged commit c437da4 into main Dec 15, 2025
3 checks passed
@Zetison Zetison deleted the fix/transmissionmode_labeling branch December 15, 2025 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Differantiate text of transmission mode variables in drop-down list for plotting

3 participants