Skip to content

Fix: Download MUSE2 release artifacts for new name format#64

Merged
alexdewar merged 1 commit into
mainfrom
ci-fix-release-artifact-name
May 13, 2026
Merged

Fix: Download MUSE2 release artifacts for new name format#64
alexdewar merged 1 commit into
mainfrom
ci-fix-release-artifact-name

Conversation

@alexdewar
Copy link
Copy Markdown
Member

@alexdewar alexdewar commented May 8, 2026

Description

After I've merged this PR on the MUSE2 repo, I'm going to rename the release artifacts for previous releases to include the version number in them, which means CI workflows on this repo will stop working. Fix by changing the name of the release artifacts downloaded to include a wildcard (which should match the old and new names).

Type of change

  • Documentation (non-breaking change that adds or improves the documentation)
  • New feature (non-breaking change which adds functionality)
  • Optimization (non-breaking, back-end change that speeds up the code)
  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (whatever its nature)

Key checklist

  • All tests pass (eg. python -m pytest)
  • Pre-commit hooks run successfully (eg. pre-commit run --all-files)

Further checks

  • Code is commented, particularly in hard-to-understand areas
  • Tests added or an issue has been opened to tackle that in the future.
    (Indicate issue here: # (issue))

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented May 8, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 47.61%. Comparing base (d75a1f2) to head (7ac52b9).
⚠️ Report is 10 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #64   +/-   ##
=======================================
  Coverage   47.61%   47.61%           
=======================================
  Files           3        3           
  Lines          42       42           
  Branches        4        4           
=======================================
  Hits           20       20           
  Misses         22       22           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@alexdewar alexdewar requested review from Aurashk and tsmbland May 11, 2026 08:34
@alexdewar alexdewar marked this pull request as ready for review May 11, 2026 08:34
Copilot AI review requested due to automatic review settings May 11, 2026 08:34
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the composite GitHub Action that installs MUSE2 from the latest release so CI keeps working after MUSE2 release artifacts are renamed to include version numbers.

Changes:

  • Adjusts gh release download --pattern to use wildcards for Windows/macOS/Linux release asset names, matching both old and new artifact naming formats.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@Aurashk
Copy link
Copy Markdown
Contributor

Aurashk commented May 12, 2026

Pattern change looks good, but you may need to do more to get this to work. The extract/set muse2 path names require an exact path provided by inputs.muse2_exe. Maybe extracting the release tag/name from gh release view and get rid of the exe name input?

@alexdewar
Copy link
Copy Markdown
Member Author

Pattern change looks good, but you may need to do more to get this to work. The extract/set muse2 path names require an exact path provided by inputs.muse2_exe. Maybe extracting the release tag/name from gh release view and get rid of the exe name input?

I don't think that's a problem, though...? gh release renames the downloaded file to muse2_asset_download, before extracting from it, so I don't think inputs.muse2_exe comes into it.

@Aurashk
Copy link
Copy Markdown
Contributor

Aurashk commented May 12, 2026

Pattern change looks good, but you may need to do more to get this to work. The extract/set muse2 path names require an exact path provided by inputs.muse2_exe. Maybe extracting the release tag/name from gh release view and get rid of the exe name input?

I don't think that's a problem, though...? gh release renames the downloaded file to muse2_asset_download, before extracting from it, so I don't think inputs.muse2_exe comes into it.

Oh yea think you're right sorry, for some reason I thought you were changing the exe names to include version numbers too. I think it's fine in that case

@alexdewar
Copy link
Copy Markdown
Member Author

I've confirmed this works with the renamed release artifacts, so I think it's good to go

@alexdewar alexdewar enabled auto-merge May 13, 2026 11:45
@alexdewar alexdewar merged commit 1a52ddb into main May 13, 2026
19 checks passed
@alexdewar alexdewar deleted the ci-fix-release-artifact-name branch May 13, 2026 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants