feat: promote skill-trigger to built-in evaluator (rename from trigger-judge)#609
Merged
feat: promote skill-trigger to built-in evaluator (rename from trigger-judge)#609
Conversation
…ger-judge) Fixes a leaky abstraction: the transpiler had hardcoded references to 'trigger-judge' but the implementation only lived in an example directory. - Rename trigger-judge → skill-trigger throughout - Add SkillTriggerEvaluator as a built-in evaluator in @agentv/core - Add SkillTriggerEvaluatorConfig to types.ts and EvaluatorConfig union - Add 'skill-trigger' to EVALUATOR_KIND_VALUES and AssertionType - Register skill-trigger in builtin-evaluators.ts and evaluator-parser.ts - Update examples and tests to use the new name - Replace example .agentv/judges/trigger-judge.ts with a deprecation note
This was referenced Mar 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
trigger-judge→skill-triggerand moves the implementation from an example directory into agentv coreSkillTriggerEvaluatoras a built-in evaluator in@agentv/core(new filepackages/core/src/evaluation/evaluators/skill-trigger.ts)'trigger-judge'but the judge only existed inexamples/, making it an unresolved leaky abstractionChanges
packages/core/src/evaluation/evaluators/skill-trigger.ts— new built-in evaluator (ported from example judge)packages/core/src/evaluation/types.ts— adds'skill-trigger'toEVALUATOR_KIND_VALUES,SkillTriggerEvaluatorConfigtype, andEvaluatorConfigunionpackages/core/src/evaluation/loaders/eval-yaml-transpiler.ts— replaces all'trigger-judge'with'skill-trigger'packages/core/src/evaluation/loaders/evaluator-parser.ts— addsskill-triggerparse casepackages/core/src/evaluation/registry/builtin-evaluators.ts— registersskill-triggerfactorypackages/eval/src/assertion.ts— adds'skill-trigger'toAssertionTypeexamples/features/transpile/csv-analyzer.EVAL.yaml— updated to usetype: skill-triggerexamples/features/agent-skills-evals/.agentv/judges/trigger-judge.ts— replaced with deprecation notepackages/core/test/evaluation/loaders/eval-yaml-transpiler.test.ts— updated all referencesRisk
Low — rename + promotion. No behavior change; the evaluation logic is identical to the example judge. All 1340 tests pass, lint clean, build and typecheck pass.