Skip to content

fix(targets): drop deprecated pi_provider aliases #727

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
christso merged 1 commit into from
Mar 24, 2026
Merged

fix(targets): drop deprecated pi_provider aliases #727

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 2 additions & 6 deletions packages/core/src/evaluation/providers/targets.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1416,9 +1416,7 @@ function resolvePiCodingAgentConfig(
evalFilePath?: string,
): PiCodingAgentResolvedConfig {
const executableSource = target.executable ?? target.command ?? target.binary;
// subprovider is canonical; pi_provider, piProvider, llm_provider are deprecated aliases
const subproviderSource =
target.subprovider ?? target.pi_provider ?? target.piProvider ?? target.llm_provider;
const subproviderSource = target.subprovider;
const modelSource = target.model ?? target.pi_model ?? target.piModel;
const apiKeySource = target.api_key ?? target.apiKey;
const toolsSource = target.tools ?? target.pi_tools ?? target.piTools;
Expand Down Expand Up @@ -1533,9 +1531,7 @@ function resolvePiAgentSdkConfig(
target: z.infer<typeof BASE_TARGET_SCHEMA>,
env: EnvLookup,
): PiAgentSdkResolvedConfig {
// subprovider is canonical; pi_provider, piProvider, llm_provider are deprecated aliases
const subproviderSource =
target.subprovider ?? target.pi_provider ?? target.piProvider ?? target.llm_provider;
const subproviderSource = target.subprovider;
const modelSource = target.model ?? target.pi_model ?? target.piModel;
const apiKeySource = target.api_key ?? target.apiKey;
const timeoutSource = target.timeout_seconds ?? target.timeoutSeconds;
Expand Down