Skip to content

Use CMake_jll so that users don't need to install it manually#478

Open
vchuravy wants to merge 3 commits intomainfrom
vc/cmake
Open

Use CMake_jll so that users don't need to install it manually#478
vchuravy wants to merge 3 commits intomainfrom
vc/cmake

Conversation

@vchuravy
Copy link
Member

@vchuravy vchuravy commented Oct 3, 2022

No description provided.

@vchuravy vchuravy requested a review from wsmoses October 3, 2022 19:18
@wsmoses
Copy link
Member

wsmoses commented Oct 4, 2022

@vchuravy relatedly do you know why julia clang on macos wasn't able to fnd the paths

@github-actions
Copy link
Contributor

Benchmark Results

main 7faa37f... main/7faa37f9bd46d9...
basics/overhead 4.34 ± 0.01 ns 4.03 ± 0.01 ns 1.08
time_to_load 0.449 ± 0.0026 s 0.448 ± 0.0037 s 1

Benchmark Plots

A plot of the benchmark results have been uploaded as an artifact to the workflow run for this PR.
Go to "Actions"->"Benchmark a pull request"->[the most recent run]->"Artifacts" (at the bottom).

@github-actions
Copy link
Contributor

Your PR requires formatting changes to meet the project's style guidelines.
Please consider running Runic (git runic main) to apply these changes.

Click here to view the suggested changes.
diff --git a/deps/build_local.jl b/deps/build_local.jl
index 452842d..4f5cb95 100644
--- a/deps/build_local.jl
+++ b/deps/build_local.jl
@@ -92,9 +92,9 @@ isdir(scratch_dir) && rm(scratch_dir; recursive=true)
 run(`$(cmake()) -DLLVM_DIR=$(LLVM_DIR) -DCMAKE_BUILD_TYPE=$(BUILD_TYPE) -DENZYME_EXTERNAL_SHARED_LIB=ON -B$(scratch_dir) -S$(source_dir)`)
 
 if BCLoad
-  run(`$(cmake()) --build $(scratch_dir) --parallel $(Sys.CPU_THREADS) -t Enzyme-$(LLVM_VER_MAJOR) EnzymeBCLoad-$(LLVM_VER_MAJOR)`)
+    run(`$(cmake()) --build $(scratch_dir) --parallel $(Sys.CPU_THREADS) -t Enzyme-$(LLVM_VER_MAJOR) EnzymeBCLoad-$(LLVM_VER_MAJOR)`)
 else
-  run(`$(cmake()) --build $(scratch_dir) --parallel $(Sys.CPU_THREADS) -t Enzyme-$(LLVM_VER_MAJOR)`)
+    run(`$(cmake()) --build $(scratch_dir) --parallel $(Sys.CPU_THREADS) -t Enzyme-$(LLVM_VER_MAJOR)`)
 end
 
 # Discover built libraries

@giordano
Copy link
Member

relatedly do you know why julia clang on macos wasn't able to fnd the paths

Clang_jll knows nothing about system paths, you need to instruct it a little bit. And macOS in particular has well hidden system paths. You could try something xcrun --sdk macosx --show-sdk-path (from JuliaLang/julia#47184 (comment))

@wsmoses
Copy link
Member

wsmoses commented Sep 18, 2025

fair, also relatedly @giordano we could also do something like this for reactant with bazel_jll on systems it's supported which might be nice for people given bazel nonsense to install

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants