Conversation
lukehb
added
bug
mcottontensor
approved these changes
Jul 24, 2024
This was referenced Jul 24, 2024
Contributor
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
lukehb
added a commit
that referenced
this pull request
Jul 24, 2024
[UE5.5] Merge pull request #204 from EpicGamesExt/ff-fix
lukehb
changed the title
3 tasks
mcottontensor
added a commit
that referenced
this pull request
Jul 25, 2024
[UE5.2] Merge pull request #204 from EpicGamesExt/ff-fix
mcottontensor
added a commit
that referenced
this pull request
Jul 25, 2024
[UE5.3] Merge pull request #204 from EpicGamesExt/ff-fix
mcottontensor
added a commit
that referenced
this pull request
Jul 25, 2024
[UE5.4] Merge pull request #204 from EpicGamesExt/ff-fix
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relevant components:
Problem statement:
In FireFox 128.0 FireFox add support for the setCodecPreference API. This triggered a codepath that was previously only tested on Chrome to be executed. That codepath was unable to handle the slight difference codec parameters specified by Firefox and resulted in no codec being selected by the preferred codec API - meaning the browser would not display VPX video.
Solution
The solution was to make this code path more robust to mismatched parameters and if the parameters are unable to be matched then it will fallback to only using the codec name. This should be robust to future browser changes in Chrome, FireFox, Safari, etc.
Documentation
N/A
Test Plan and Compatibility
Test with:
All are able to connect.