Conversation
Not sure if this is necessary - thoughts?
Allows tests to pass
While I understand the reason, but it would seem weird if the format contain {} and one contain %% in the same config file on the other hand. |
|
@Banbeucmas It's more clear whether a placeholder comes from EssentialsX or PlaceholderAPI if they have different characters surrounding them. |
|
Essentials placeholder already use uppercase character for most of the time , I think it is safe to just use {} to replace %%. |
|
@Banbeucmas The Essentials docs and config usually include capitalised tokens, but they are usually case-insensitive when replaced as far as I remember. Regardless, it would be simpler for PAPI placeholders to work the same in EssentialsX as they do in every single other plugin that supports PAPI (just |
|
I guess that will be how it's goes then. Up to you. |
|
Using |
|
@extendedclip Thanks for the heads-up. I've added this to the to-do. |
|
There are issues with the approach taken in this PR, and for that reason I'm going to close this. #2502 is a better base for this to be implemented on. |
This PR cherry-picks commits from #1944. The differences between this PR and #1944 are:
User.sendMessagerather than in a newFormatUtil.tlpmethod{...}with%...%, as that would be confusing for users when old Essentials placeholders breakTo do:
%s in chat formatCredits go to @Banbeucmas for the original PR.
Closes #1945, closes #1944, closes #1959, yada yada