Allow configuring which types of messages get sent as webhook for Discord#5158
Closed
x86-39 wants to merge 5 commits intoEssentialsX:2.xfrom
x86-39:discord-configure-types-webhook
Closed
Allow configuring which types of messages get sent as webhook for Discord#5158x86-39 wants to merge 5 commits intoEssentialsX:2.xfrom x86-39:discord-configure-types-webhook
x86-39 wants to merge 5 commits intoEssentialsX:2.xfrom
x86-39:discord-configure-types-webhook
Conversation
3 tasks
Contributor
Author
|
Hey @pop4959, this PR has been open for 1.5 years now, do you have the chance to look at this and potentially merge it? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Information
This PR partially closes #5155
Details
Proposed feature:
Allow configuring which types of messages get sent as a webhook.
Currently when enabling the webhook feature all player specific messages get sent as a webhook. This may not always be desired since this also includes joining the server, deaths, advancements etc.
Environments tested:
OS: Fedora 36
Java version:
17.0.5Don't see how this could differ on other server versions.
Demonstration:
This should send all messages as the normal bot user still, but leave chat messages, afk messages and actions as the player.
(Chat messages use a different code path and can't be configured like this, neither can server messages obviously)
(first-join option is from #5160)
(placeholder in username is from #5159)