still fixing the configurate pr#5438
Merged
mdcfe merged 2 commits intoEssentialsX:2.xfrom Jul 22, 2023
Merged
Conversation
More than just a SerializationException can happen I guess
Invalid material names would previously return a null value when deserializing. This raises an exception from within Configurate because they use an EnumSet internally during deserialization which doesn't support null elements.
JRoy
added
type: bugfix
mdcfe
reviewed
Jul 22, 2023
mdcfe
approved these changes
Jul 22, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #5409
read patch notes
rebase and merge