Conversation
JRoy
added
type: bugfix
This exact code exists in ModernUserMap#getUser(String)
The usermap will already do this on its own, and we should really avoid doing this outside the usermap to avoid unforeseen behavior changes.
In theory this should never be an issue but somehow is?
This can lead to the potential that a UUID can be mapped to the improper name. This logic should be handled the join logic.
Allows to view the number of known UUIDs as well as name to UUID pairs.
JRoy
force-pushed
the
fix/usermap-cache-woahs
branch
from
f280a37 to
57253b9
Compare
mdcfe
approved these changes
Aug 5, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
read the patch notes and code comments
rebase and merge
Closes #5455