ISSUE#6502 fix: PlayerList appends literal <white> tag in customtext output#6503
Open
9ne7ven wants to merge 1 commit intoEssentialsX:2.xfrom
Open
ISSUE#6502 fix: PlayerList appends literal <white> tag in customtext output#65039ne7ven wants to merge 1 commit intoEssentialsX:2.xfrom
9ne7ven wants to merge 1 commit intoEssentialsX:2.xfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Title: {PLAYERLIST} placeholder appends literal MiniMessage tag in custom.txt
Description:
When using {PLAYERLIST:group} placeholder inside custom.txt, the output contains a literal tag appended after each player name instead of being parsed as MiniMessage.
Steps to reproduce:
Create a custom.txt with {PLAYERLIST:groupname}
Alias /list to customtext list in commands.yml
Run /list ingame
custom.txt
commands.yml
Ingame chat output of /list
Expected behavior: Player names display correctly with no visible tags
Actual behavior: white tag is rendered as plain text see screenshot above on Ingame input.
Root cause: In PlayerList.java line 36 : groupString.append(""); is hardcoded but never parsed when output goes through customtext
Version: EssentialsX 2.21.0 / Paper 1.21
After compiling and testing this is the result with the PR request (reference to screenshot below)
