Fix VanishStatusChangeEvent NPE and document parameter inversion#6510
Merged
JRoy merged 1 commit intoEssentialsX:2.xfrom Apr 12, 2026
Merged
Fix VanishStatusChangeEvent NPE and document parameter inversion#6510JRoy merged 1 commit intoEssentialsX:2.xfrom
JRoy merged 1 commit intoEssentialsX:2.xfrom
Conversation
The affected/controller parameters are swapped in Commandvanish (EssentialsX#2604) but cannot be fixed without breaking the public API. Fix BukkitListener to use getController() (the actual vanished player) instead of getAffected() (the sender, null for console), and add inversion warning javadoc matching the NickChangeEvent pattern. Fixes EssentialsX#6388
Closed
3 tasks
mdcfe
approved these changes
Apr 12, 2026
Member
mdcfe
left a comment
mdcfe
left a comment
There was a problem hiding this comment.
Only possible suggestion would be adding a set of "get real affected / controller" methods, but those would be redundant
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The affected/controller parameters are swapped in Commandvanish (#2604) but cannot be fixed without breaking the public API.
Fix BukkitListener to use getController() (the actual vanished player) instead of getAffected() (the sender, null for console), and add inversion warning javadoc matching the NickChangeEvent pattern.
Fixes #6388