Skip to content

fix: prevent zombie client re-insertion after disconnectClient #88

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
EtanHey merged 1 commit into from
Mar 18, 2026
Merged

fix: prevent zombie client re-insertion after disconnectClient #88

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion brain-bar/Sources/BrainBar/BrainBarServer.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,6 +173,8 @@ final class BrainBarServer: @unchecked Sendable {
if !response.isEmpty {
sendResponse(fd: fd, response: response)
}
// sendResponse may have called disconnectClient — stop processing
if clients[fd] == nil { return }
}

clients[fd] = state
Expand Down Expand Up @@ -200,7 +202,11 @@ final class BrainBarServer: @unchecked Sendable {
disconnectClient(fd: fd)
return
}
if n == 0 { break } // EOF
if n == 0 {
NSLog("[BrainBar] Write returned 0 on fd %d — peer closed", fd)
disconnectClient(fd: fd)
return
}
totalWritten += n
eagainRetries = 0 // reset on successful partial write
}
Expand Down
Loading