Scroll buttons on main menu (issue #793)#880
Conversation
maddie480
added
the
1: review needed
SnipUndercover
left a comment
SnipUndercover
left a comment
There was a problem hiding this comment.
Looks good, I just want to test this myself before approving.
Wartori54
left a comment
Wartori54
left a comment
There was a problem hiding this comment.
It works, yet it doesn't feel right, the scrolling is not smooth at all and breaks the style of Celeste menus. I believe adding the same smoothing on scroll that text menus have would work nicely and fit perfectly, if that's added that's an immediate LGTM on my end.
But I know this may be asking too much, so I will ask, instead, for a TODO to get added in the relevant part asking for someone to implement smooth scrolling in the future.
DashingCat
force-pushed
the
793-scroll_buttons_on_main_menu
branch
from
7f1fbbf to
07aaf62
Compare
|
Thanks @Wartori54 for the review, I added a |
maddie480-bot
added
2: changes requested
|
The pull request was approved and entered the 3-day last-call window. |
maddie480-bot
added
3: last call window
|
The last-call window for this pull request ended. It can now be merged if no blockers were brought up. |
maddie480-bot
added
4: ready to merge
6 participants
Allow buttons to scroll in the main menu so the currently selected button is always on screen.
Closes #793.