feat: prefer global fetch on Node.js#20
Merged
Merged
Conversation
mvayngrib
approved these changes
Aug 3, 2024
Contributor
Author
It is, technically
No Clients should expect to be compatible with browser/global fetch already though, as they are used in different envs Also, this can be overriden in specific setups |
|
🎉 This PR is included in version 1.5.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Native
fetchis no longer behind the experimental flag since Node.js 18.0.0, and is marked stable since Node.js 21.0.0And the current impl in v20.11+ is newer then the one in v21.0.0
This leaves the backwards-compat in place with environments with no global fetch, and only prefers it over
node-fetchWe can remove
node-fetchfallback in v2 or v1 as we don't really need it anymore and all supported Node.js versions have global fetch