Profile - Growl is missing "Your profile has been saved successfully" when saved the changes.

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Go to URL https://staging.new.expensify.com/
2. Login with any account
3. Go to profile sections and make any changes
4. Click Save button

Expected Result:

The message "Your profile has been saved successfully" should be present

Actual Result:

Growl is missing "Your profile has been saved successfully" when saved the changes.

Workaround:

Unknown

Platform:

Where is this issue occurring?

• Web
• iOS
• Android
• Desktop App
• Mobile Web

Version Number: 1.1.87.8

Reproducible in staging?: Yes

Reproducible in production?: No

Email or phone of affected tester (no customers): any

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug5673188_Recording__1340.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @tgolen (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[tgolen]

Hm, I'm looking into this a little bit, and because of our refactoring, the growl was intended to be removed. However, there are some problems with the submit button on this form:

What I am seeing is...

• Edit name
• Click on save
• button becomes disabled
• API request is successful
• button remains disabled
• Edit name again
• button is still disabled
• click on the button
• API request is successful

So... a couple of things.

1. The button should be enabled again after the request is successful
2. Clicking on a disabled button should not allow the form to be submitted

[tgolen]

I reached out to a few people in Slack to see if they can provide insight to the functionality, so I am waiting to hear back from that. If I don't hear anything tomorrow, let's consider reverting the user settings profile change.

cc @marcaaron @yuwenmemon

[Beamanator]

Oofda this was probably my change, I'll look into it now

[Beamanator]

Looks like the problem is with the button styling, not button being disabled - the button is somehow a bit grayed out after editing, saving, and editing again - but it's not actually disabled (via isButtonDisabled)

Completely disabled: Opacity 0.5
Slight gray styling: Opacity 0.827092 (this changes somehow!!)
Normal button: Opacity 1

[Beamanator]

Something interesting I'm seeing: When we have the old PersonalDetails.setPersonalDetails code, dimming & un-dimming (via OpacityView) finishes:

However, when we use my updated code (PersonalDetails.updateProfile), dimming and undimming DOESN'T finish:

I believe this is due to the fact that we're now immediately changing the Onyx state after clicking the button, so the animation in OpacityView doesn't have time to finish undimming the button (making it full opacity)

[Beamanator]

I got the ^ "finished dimming / undimming" logs by adding console logs here:

• Note: adding this.opacity to those logs confirmed my theory -> The animation finishes before opacity is set back to 1 completely