Login - When entering 2 digits, the wrong message is displayed

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Issue found when executing PR #10197

Action Performed:

1. Go to NewDot login page
2. Type 2 digits and continue

Expected Result:

The message error shows: Please enter a valid phone number, with the country code (e.g. +15005550006).

Actual Result:

In mWeb message displayed- I couldn't validate the phone number, please try again with the country code (e.g. +15005550006).
In Web - Cannot get account details, please try again

Workaround:

Unknown

Platform:

Where is this issue occurring?

• Web
• iOS
• Android
• Desktop App
• Mobile Web

Version Number: 1.1.88.14

Reproducible in staging?: Yes

Reproducible in production?: No

Email or phone of affected tester (no customers): any

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @flodnv (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[rushatgabhane]

PR #10197 is unrelated because it's diff doesn't have anything to do with the message in Actual result.

Is this really a deploy blocker?

[flodnv]

I agree that it seems that PR is unrelated.

I don't know if this is a deploy blocker -- it feels to me like the newer version (on staging) is better. However maybe it would be good to understand why/how this happened? This is the end of my day so I'm unassigning, cc @tgolen since you are deployer and the above PR's reviewer.

[flodnv]

Maybe this PR is related @yuwenmemon @luacmartins ? #10222

[luacmartins]

This is indeed related to #10222 and it happens because we are now sending the error message from the server. We previously replaced that server error here with a localized version in App.

The fact that the message is in English even in the Spanish app will happen in every API refactor that sends server errors back to the user. I think this is expected for the time being, although we should fix this sooner rather than later.

[flodnv]

Agreed, makes sense... so, I think we :donothing: here and it's a "feature", not a bug?