Room notification preference updates after changing the room name

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Go to URL https://staging.new.expensify.com/
2. Create a workspace from the green plus (if needed)
3. Create a workspace room from the green plus (if needed)
4. Click the header of the workspace room to open the room details page
5. Click "Settings"
6. Rename the room and hit save

Expected Result:

Only the name should be changed when you press the save key

Actual Result:

Сhanges the name and status of notifications to immediately when pressing the save key

Workaround:

Unknown

Platform:

Where is this issue occurring?

• Web
• iOS
• Android
• Desktop App
• Mobile Web

Version Number: 1.1.88.14

Reproducible in staging?: Yes

Reproducible in production?: Yes

Email or phone of affected tester (no customers): any applause account

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug5692908_Recording__1538.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @thienlnam (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[thienlnam]

Looks related to the recent changes to rename policy room cc @neil-marcellini #10237
From some testing, it seems like pressing the save button triggers the Picker onInputChange
I looked through the API changes and it doesn't touch any of the notification stuff so it seems like a bug in App, making it external

[melvin-bot]

Triggered auto assignment to @trjExpensify (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[trjExpensify]

The title of the issue confused me a bit, I think we should update it to something like: Room notification preference updates after changing the room name - what do you think?

Also to confirm, is this issue actually isolated to Web only like the title suggested? The Platform section of the OP suggests otherwise.

Lastly, user-created rooms are behind a beta still, so can this actually go external?

Thanks, @thienlnam!

[thienlnam]

Room notification preference updates after changing the room name

This issue update sounds good to me

Also to confirm, is this issue actually isolated to Web only like the title suggested? The Platform section of the OP suggests otherwise.

I've just tested this on desktop and it appears to be happening there as well so it doesn't seem to be isolated to web

Lastly, user-created rooms are behind a beta still, so can this actually go external?

Good catch on this, I didn't know this was behind a beta - this will have to be internal then

Thanks!

[trjExpensify]

Cool, sounds good. Updating the issue title and removing my assignment as a CM isn't needed.