[HOLD for payment 2022-09-16] [$250] The file extension shows up twice in the file name reported by @Tushu17

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open website/mWeb.
2. Go to chat > Send a jpeg/pdf attachment..
3. See the name of attachment in preview.

Expected Result:

Extension shouldn't get repeated.

Actual Result:

It shows up twice.

Workaround:

Unknown

Platform:

Where is this issue occurring?

• Web
• Mobile Web

Version Number: 1.1.91-0
Reproducible in staging?: Y
Reproducible in production?: Y
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:


Expensify/Expensify Issue URL:
Issue reported by: @Tushu17
Slack conversation:

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @sonialiap (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

[theTrozen77]

Hi, I have been able to reproduce this and fix it successfully.
return {fileName: splitFileName[0], fileExtension};
The filename returned was not correct previously.
Thankyou

[Puneet-here]

Proposal

There are two extensions because we aren't removing the extension from file name and we are adding the extension here too

App/src/components/AttachmentModal.js

Line 241 in d5b1c82

trailingText={fileExtension ? `.${fileExtension}` : ''}

The above proposal doesn't work great when a file name has periods in it. It will take the text before the period so the file name will be incomplete.
We can use slice(0, -1).join('.') after split. This way we will get the whole file name without extension then we just have to use that instead of the one with the extension.

[melvin-bot]

@sonialiap Whoops! This issue is 2 days overdue. Let's get this updated quick!

[sonialiap]

Triaging, can confirm described behavior

[melvin-bot]

Triggered auto assignment to @johnmlee101 (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.