[$250] Web - Settings/About - "View keyboard shortcuts" is missing in the minimal window

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Go to URL https://staging.new.expensify.com/
2. Login with any account
3. Go to Settings -> About
4. Verify that "View keyboard shortcuts" is present
5. Minimize the window

Expected Result:

"View keyboard shortcuts" should be present

Actual Result:

"View keyboard shortcuts" is missing

Workaround:

Unknown

Platform:

Where is this issue occurring?

• Web

Version Number: 1.2.25.0

Reproducible in staging?: Yes

Reproducible in production?: Yes

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug5812660_Recording__2832.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @alexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[hungvu193]

Well I think that's the feature, not a bug.

App/src/pages/settings/AboutPage/getPlatformSpecificMenuItems/index.js

Lines 1 to 15 in 7e8a00d

	import * as KeyboardShortcuts from '../../../../libs/actions/KeyboardShortcuts';
	import * as Expensicons from '../../../../components/Icon/Expensicons';
	export default (isSmallScreenWidth) => {
	if (isSmallScreenWidth) {
	return [];
	}
	return [
	{
	translationKey: 'initialSettingsPage.aboutPage.viewKeyboardShortcuts',
	icon: Expensicons.Keyboard,
	action: KeyboardShortcuts.showKeyboardShortcutModal,
	},
	];
	};

In case we want to fix this, we can remove checking the isSmallScreenWidth in getPlatformSpecificMenuItems/index.js or passing the value false to getPlatformSpecificMenuItems function in AboutPage.js.

- export default (isSmallScreenWidth) => { 
+  export default () => { 
-     if (isSmallScreenWidth) { 
-         return []; 
-     } 
     return [ 
         { 
             translationKey: 'initialSettingsPage.aboutPage.viewKeyboardShortcuts', 
             icon: Expensicons.Keyboard, 
             action: KeyboardShortcuts.showKeyboardShortcutModal, 
         }, 
     ]; 
 };

or in AboutPage.js:

-const platformSpecificMenuItems = getPlatformSpecificMenuItems(props.isSmallScreenWidth);
+const platformSpecificMenuItems = getPlatformSpecificMenuItems(false);

Screen.Recording.2022-11-09.at.17.27.37.mov

[melvin-bot]

Current assignee @alexpensify is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mananjadhav (External)

[melvin-bot]

Triggered auto assignment to @AndrewGable (External), see https://stackoverflow.com/c/expensify/questions/7972 for more details.