Line break is removed when edit the quoted text reported by @0xmiroslav

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Login with any account
2. Go to any chat room
3. Type and send this message:
   Test1
   Test2
   Test3
4. Click Edit icon from context menu

Expected Result:

Edit input is filled same as before send message:
Test1
Test2
Test3

Actual Result:

Edit input is filled like this:
Test1```
Test2
``
Test3

Workaround:

unknown

Platform:

Where is this issue occurring?

• Web
• iOS
• Android
• Desktop App
• Mobile Web

Version Number: 1.2.28-0
Reproducible in staging?: y
Reproducible in production?: y
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:

Recording.947.mp4

quote.mov

Expensify/Expensify Issue URL:
Issue reported by: @0xmiroslav
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1668591483946799

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @miljakljajic (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[iwiznia]

Alright, did some investigations for this issue. The problem was introduced here to solve this issue and I think also here to solve this.
When leaving the following comment:

It is replacing <\pre><br> with just <pre> and <br><pre> with <pre>.
I am not sure how we can fix this without breaking those other cases.
While looking at this I wondered why are we not saving the exact text verbatim the user entered, that way I think we would not need an html to markup conversion and these kind of bugs would be gone....

[aldo-expensify]

While looking at this I wondered why are we not saving the exact text verbatim the user entered

Like, why we don't just save the markdown?

[0xmiroslav]

Like, why we don't just save the markdown?

@iwiznia already opened slack discussion here

[melvin-bot]

@miljakljajic Huh... This is 4 days overdue. Who can take care of this?

[iwiznia]

Like, why we don't just save the markdown?

No, why don't we save exactly what the user typed, the convert it to whatever we want. Anyway, closing this.

so long as the edited version is semantically the same as the original (eg, both produce the same HTML), it's not a bug.