Message stays highlighted after closing the context menu

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Navigate to a chat
2. Send a message
3. Right click on the message
4. Click anywhere at the screen to close the context menu

Expected Result:

The message shouldn't be highlighted after closing the context menu

Actual Result:

The message stays highlighted

Workaround:

unknown

Platform:

Where is this issue occurring?

• Web
• iOS
• Android
• Desktop App
• Mobile Web

Version Number: 1.2.29-6
Reproducible in staging?: y
Reproducible in production?: n
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:

Recording.981.mp4

Screen.Recording.2022-11-19.at.3.09.05.PM.mov

Expensify/Expensify Issue URL:
Issue reported by: @thesahindia
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1668851137899819

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @flaviadefaria (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @amyevans (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[hungvu193]

Proposal
The ReportActionItem will be highlight when it's hovered or the PopoverReportActionContextMenu is visible.
Even when the PopoverReportActionContextMenu is dismissed, the reportAction state is not getting reset so the function to check PopoverReportActionContextMenu is isActiveReportAction still return true.

Solution
Reset the reportAction state to {} when PopoverReportActionContextMenu is dismissed.
So inside PopoverReportActionContextMenu udpate the hideContextMenu:

    /**
     * Hide the ReportActionContextMenu modal popover.
     * @param {Function} onHideActionCallback Callback to be called after popover is completely hidden
     */
    hideContextMenu(onHideActionCallback) {
        if (_.isFunction(onHideActionCallback)) {
            this.onPopoverHideActionCallback = onHideActionCallback;
        }
        this.setState({
            selection: '',
            reportActionDraftMessage: '',
            isPopoverVisible: false,
+           reportAction: {},
        });
    }

Result:

Screen.Recording.2022-11-21.at.23.01.58.mov

[amyevans]

This is a regression caused by #12735, cc @deetergp @Pujan92 @mananjadhav @Julesssss.

I'll open a revert of that PR.