Chat - Pin icon flashes after switching back to online

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Issue found when executing PR #14608

Action Performed:

1.Go offline
2.Pin a chat
3.Unpin a chat
4.Pin a chat again
5.Go online

Expected Result:

Chat ends up in the correct state of "pinned" without any blinking

Actual Result:

Pin icon flashes after switching back to online

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.2.63.0

Reproducible in staging?: Yes

Reproducible in production?: Yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug5920063_14608_web.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~019efbe2b8f3460e9e
• Upwork Job ID: 1620912782462525440
• Last Price Increase: 2023-02-01

[mountiny]

I think this is to some extent expected because all the actions made offline are queued to be done when user comes back online. Hence if user will toggle the settings there and back while offline and comes back online, the requests will be sequentially made to the server resulting in this flickering behaviour. it does not look great, but I think this is not strictly a bug.

[greg-schroeder]

Gotcha, thanks for that context @mountiny - do you think we should close this for now then to focus on other items?

[mountiny]

@greg-schroeder Now I have noticed the issue is mentioning a PR #14608 where this was noticed. It might not be related but it might be worth:

• check if engineer can repro locally on main
• reverting that change in the mentioned PR locally
• check if you can repro after the change

That would confirm this was caused by that PR.

If not, then I would probably close this.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~019efbe2b8f3460e9e

[melvin-bot]

Triggered auto assignment to Contributor Plus for review of internal employee PR - @thesahindia (Internal)

[mountiny]

@greg-schroeder can you also add Engineering so it picks someone internal, thanks!

[mountiny]

Yep sorry, missed before this is coming form latest deploy #14709 (comment) so we should investigate if this is not a deploy blocker actually cc @thienlnam